fix: prefer unresolved sys.executable to stay inside venv#310
Merged
fix: prefer unresolved sys.executable to stay inside venv#310
Conversation
On macOS with Homebrew Python, `Path(sys.executable).resolve()` follows the venv symlink back to the system interpreter. PEP 668 then blocks pip installs with "externally-managed-environment", causing the setup tour to fail. Swap the check order so the unresolved venv path is preferred when it exists, falling back to the resolved path only when necessary. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_resolve_python()instart_tour.pyresolves venv symlinks back to the system interpreter. PEP 668 then blockspip installwith an "externally-managed-environment" error, causing the setup tour to fail.sys.executable) is preferred when it exists, falling back to the resolved path only when necessary.Test plan
python -m venv .venv && source .venv/bin/activate && python scripts/start_tour.pyon macOS with Homebrew Python🤖 Generated with Claude Code